[LSP] Remove isFinalized from semantic tokens logic #60322
Closed
+16
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonchou
requested review from
ryanbrandenburg,
davidwengier,
dibarbet and
NTaylorMullen
dibarbet
reviewed
Mar 22, 2022
| @@ -147,10 +147,12 @@ static SemanticTokensHelpers() | |||
|
|
|||
| // If the full compilation is not yet available, we'll try getting a partial one. It may contain inaccurate | |||
| // results but will speed up how quickly we can respond to the client's request. | |||
| var frozenDocument = document.WithFrozenPartialSemantics(cancellationToken); | |||
| var semanticModel = await frozenDocument.GetRequiredSemanticModelAsync(cancellationToken).ConfigureAwait(false); | |||
| var isFinalized = document.Project.TryGetCompilation(out var compilation) && compilation == semanticModel.Compilation; | |||
There was a problem hiding this comment.
is this because of the issue where the compilation out of proc is not necessarily finalized when the compilation in proc is? Or is checking for the compilation here just not correct?
Is this not an issue for regular C# tagger too @CyrusNajmabadi ? It looks like we use the compilation available event there as well, which I presume is coming from the in-proc version - https://sourceroslyn.io/#Microsoft.CodeAnalysis.EditorFeatures/Classification/Semantic/AbstractSemanticOrEmbeddedClassificationViewTaggerProvider.cs,65
|
Superseded by #60484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property is currently only used by Razor - see dotnet/razor#6194 for details.
Will likely have to be dual inserted with the Razor PR